[Proftpd-devel] mod_ldap LDAPUsers parameter bug

[Peter Marshall]

In mod_ldap.c, v2.9.3 there is a bug with the LDAPUsers config value.

set_ldap_userlookups was ignoring the last parameter, so any attempt to
set a "uid-number-filter-template" failed. The default filter is applied
ok, but any attempt to change it results in no filter.

Here's a patch which addresses the fault:

--- ../mod_ldap/mod_ldap.c 2014-11-13 08:47:22.328573698 +0100
+++ contrib/mod_ldap.c 2014-11-13 09:50:42.824638637 +0100
@@ -1716,6 +1716,9 @@
if (cmd->argc > 2) {
c->argv[1] = pstrdup(c->pool, cmd->argv[2]);
}
+ if (cmd->argc > 3) {
+ c->argv[2] = pstrdup(c->pool, cmd->argv[3]);
+ }

return PR_HANDLED(cmd);
}


Cheers,
Pete.

[TJ Saunders]

Post by Peter Marshall
In mod_ldap.c, v2.9.3 there is a bug with the LDAPUsers config value.
set_ldap_userlookups was ignoring the last parameter, so any attempt to
set a "uid-number-filter-template" failed. The default filter is applied
ok, but any attempt to change it results in no filter.

Thanks! I've filed this as:

http://bugs.proftpd.org/show_bug.cgi?id=4133

and will have the patch merged to the master branch in GitHub shortly.

Cheers,
TJ